Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bat script to run integration tests #171

Merged
merged 3 commits into from
Jul 31, 2019

Conversation

se7entyse7en
Copy link
Contributor

As part of #168.

This adds a bat script to run integration tests as we did for engine.

Integration tests can then be run as follows:

PS C:\Users\Windows10\sourced-ce> $env:SOURCED_GITHUB_TOKEN="<github token>"
PS C:\Users\Windows10\sourced-ce> .\run-integration-tests.bat

Copy link
Contributor

@dpordomingo dpordomingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have a question

:: we can't use makefile for windows because it depends on CI makefile which depends on shell

:: compile sourced-ce
if not exist build mkdir build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is not build/sourced-ce_windows_amd64 automatically created when runnuning go build -o build/sourced-ce_windows_amd64/sourced.exe ./cmd/sourced on windows? In Ubuntu it does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, the dirs are created by go build itself. Addressed here: e3b9e9e.

Signed-off-by: Lou Marvin Caraig <[email protected]>
Signed-off-by: Lou Marvin Caraig <[email protected]>
@se7entyse7en
Copy link
Contributor Author

I also changed the new line encoding to carriage return + line feed given that it is a Windows file here: a58b553.

@se7entyse7en se7entyse7en merged commit 1cdd731 into src-d:master Jul 31, 2019
@se7entyse7en se7entyse7en deleted the integration-tests-windows branch July 31, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants