New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid "console" funcs #28

Open

2 tasks

dpordomingo opened this issue May 16, 2018 · 4 comments

Labels

enhancement new feature

Contributor

dpordomingo commented May 16, 2018

from #16 (comment)

It could be a good idea

to forbid console commands (.eslintrc.js::rules['no-console']), and
to provide a logger wrapper as in CAT?

The text was updated successfully, but these errors were encountered:

dpordomingo added enhancement new feature labels

dpordomingo mentioned this issue

Merged

Contributor

smacker commented May 16, 2018

console is forbidden already (as a warning):
https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/rules/errors.js#L23

Contributor Author

dpordomingo commented May 18, 2018

but ci does not fail with warnings, does it?

Contributor

smacker commented May 18, 2018

nope. And this allows PR like this: https://github.com/src-d/gitbase-playground/pull/35/files#diff-48bb2e3e3e5708d8083b1cff1fff3949R81 which isn't bad at this stage of the project. :)

Contributor Author

dpordomingo commented May 18, 2018

The point of this issue is to address this matter whenever we're ready to do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment