Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug: improve logging information and formatter. #113

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Debug: improve logging information and formatter. #113

merged 1 commit into from
Aug 19, 2023

Conversation

ILB-96
Copy link
Contributor

@ILB-96 ILB-96 commented Aug 15, 2023

Pull Request Title

Simple and better logging experience for feature debugging

Description

modify logging config for improved readability, separation of levels.

Type

  • Bug Fix
  • Feature Enhancement
  • Documentation Update
  • Code Refactoring
  • Other (please specify): logging configuration

Proposed Changes

  • logger module in utils was created.
  • seperated logic of logging config from run_first.py to a different module
  • added coloring and file name of logging source

Screenshots / Code Snippets (if applicable)

image

How to Test

use python run_first.py

Checklist

  • The code compiles successfully without any errors or warnings
  • The changes have been tested and verified
  • The documentation has been updated (if applicable)
  • The changes follow the project's coding guidelines and best practices
  • The commit messages are descriptive and follow the project's guidelines
  • All tests (if applicable) pass successfully
  • This pull request has been linked to the related issue (if applicable)

srbhr
srbhr approved these changes Aug 19, 2023
View reviewed changes
Copy link
Owner

@srbhr srbhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Hazannovich for this.

@srbhr srbhr merged commit 88dd59c into srbhr:main Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srbhr srbhr srbhr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ILB-96 @srbhr