Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readonly properties #3699

Closed
sheridans opened this issue Oct 21, 2022 · 2 comments
Closed

Readonly properties #3699

sheridans opened this issue Oct 21, 2022 · 2 comments

Comments

@sheridans
Copy link

Describe the bug

When declaring readonly properties, current can be public readonly or readonly public both will pass sniff. I would assume it should be public readonly. Not sure if this is down to the individual coding standards or the right place to post.
@jrfnl
Copy link
Contributor

jrfnl commented Oct 21, 2022

There is already a PR open for this. See #3637

@sheridans
Copy link
Author

Missed that one! thank you will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrfnl @sheridans