CSS tokenizer does not tokenize class names correctly when they contain the string NEW #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Came across this while working on some of the Squiz CSS sniffs.
This code sample:
```css
.HelpWidgetType-new-bug-title {}
```
Was tokenized as:
```
0 :: L001 :: C1 :: T_OPEN_TAG :: (0) ::
1 :: L001 :: C1 :: T_STRING_CONCAT :: (1) :: .
2 :: L001 :: C2 :: T_STRING :: (14) :: HelpWidgetType
3 :: L001 :: C16 :: T_MINUS :: (1) :: -
4 :: L001 :: C17 :: T_NEW :: (3) :: new
5 :: L001 :: C20 :: T_STRING :: (10) :: -bug-title
6 :: L001 :: C30 :: T_WHITESPACE :: (1) ::
7 :: L001 :: C31 :: T_OPEN_CURLY_BRACKET :: (1) :: {
8 :: L001 :: C32 :: T_CLOSE_CURLY_BRACKET :: (1) :: }
```
...while I would expect the class identifier to be tokenized as one T_STRING `HelpWidgetType-new-bug-title` instead.
This commit fixes that and the code sample is now tokenized as:
```
0 :: L001 :: C1 :: T_OPEN_TAG :: (0) ::
1 :: L001 :: C1 :: T_STRING_CONCAT :: (1) :: .
2 :: L001 :: C2 :: T_STRING :: (28) :: HelpWidgetType-new-bug-title
3 :: L001 :: C30 :: T_WHITESPACE :: (1) ::
4 :: L001 :: C31 :: T_OPEN_CURLY_BRACKET :: (1) :: {
5 :: L001 :: C32 :: T_CLOSE_CURLY_BRACKET :: (1) :: }
```
No additional unit tests needed as the existing unit test in the `Squiz/Tests/CSS/SemicolonspacingUnitTest.css` file already covers this (as that's how I came across it).
gsherwood
changed the title
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this while working on some of the Squiz CSS sniffs.
This code sample:
.HelpWidgetType-new-bug-title {}Was tokenized as:
...while I would expect the class identifier to be tokenized as one T_STRING
HelpWidgetType-new-bug-titleinstead.This commit fixes that and the code sample is now tokenized as:
No additional unit tests needed as the existing unit test in the
Squiz/Tests/CSS/SemicolonspacingUnitTest.cssfile already covers this (as that's how I came across it).