FUNCTION and CONST in use groups being tokenised as T_FUNCTION and T_CONST #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsherwood
changed the title
|
Thanks for fixing those token |
wmfgerrit
pushed a commit
to wikimedia/mediawiki-tools-codesniffer
that referenced
this pull request
May 12, 2020
phpcs was fixed upstream with 3.4.0 Fixed bug #2212 : FUNCTION and CONST in use groups being tokenised as T_FUNCTION and T_CONST link: squizlabs/PHP_CodeSniffer#2212 Change-Id: Id6894e52a0f3347c4e7d4432e46a8689d6a447c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added example to the test for
Squiz.WhiteSpace.FunctionSpacingwhich has a problem with this (refs libero/php-coding-standard#30).