Batch process files in a PHP app? #2207

dingo-d · 2018-10-28T09:59:04Z

This issue connects to the #2035 issue. I made some progress in the meantime, but I'm still not getting any results.

I'm rewriting the WordPress theme sniffer plugin and in my run_sniffer() ajax callback method I have

public function run_sniffer() {
  // A lot of settings I get from the plugin and from what user selects.

  $runner = new Runner();

  $runner->config            = new Config( [ '-s' ] );
  $runner->config->standards = $standards_array;

  // Set default standard.
  Config::setConfigData( 'default_standard', 'WPThemeReview', true );

  // Ignoring warnings when generating the exit code.
  Config::setConfigData( 'ignore_warnings_on_exit', true, true );

  // Show only errors?
  Config::setConfigData( 'show_warnings', $show_warnings, true );

  // Set minimum supported PHP version.
  Config::setConfigData( 'testVersion', $minimum_php_version . '-', true );

  // Set text domains.
  Config::setConfigData( 'text_domain', implode( ',', $args['text_domains'] ), true );

  if ( $theme_prefixes !== '' ) {
    // Set prefix.
    Config::setConfigData( 'prefixes', $theme_prefixes, true );
  }

  $runner->config->files       = array_values( $all_files );
  $runner->config->annotations = $ignore_annotations;
  $runner->config->parallel    = 32;
  $runner->config->colors      = false;
  $runner->config->tabWidth    = 0;
  $runner->config->reportWidth = 110;
  $runner->config->interactive = false;
  $runner->config->cache       = false;
  $runner->config->ignored     = $ignored;

  $runner->init();

  $runner->reporter = new Reporter( $runner->config );

  \wp_send_json_success( $runner->reporter->printReports() );
}

What I get back from the ajax is {"success":true,"data":true}.

I logged the config and runner class, and the config is picked up

log output when adding error_log( print_r( $this->config, true ) ); in init() method of Runner.php

It looks like no report is being generated.

If I add

$runner->runPHPCS();

after the init() I get errors, as this deletes the config and it will report missing argv parameters and such.

I'm trying to sniff everything at once (that's why I'm using the parallel option). I'd like to avoid the previous way where I ran the sniffer every time on a single file (which takes a long time to process and is memory expensive).

Also I'm not sure Config::setConfigData parts in my code are being picked up in the runner.

I'm not sure what part am I missing here.

The text was updated successfully, but these errors were encountered:

dingo-d · 2018-11-04T18:22:15Z

Ok, I think I finally understood what @gsherwood meant by 'using your own runner'. After some debugging I realized that I need to add this to my code

$runner->reporter = new Reporter( $runner->config );

foreach ( $all_files as $file_path ) {
  $file = new DummyFile( file_get_contents( $file_path ), $runner->ruleset, $runner->config );
  $file->path = $file_path;

  $runner->processFile( $file );
}

Which works, and I'm getting the results. I'm just wondering does this means that the parallel option is useless, no?

gsherwood · 2018-11-05T02:51:44Z

Sorry, I haven't had time to look into this. Work is really crazy so I'm not sure when I will.

But I can say that you understood what I meant by doing your own runner. And yes, if you do this, you can't use the parallel feature of the main runner - you'd have to implement that yourself.

dingo-d · 2018-11-05T07:38:23Z

Awesome. I'll look into the implementation of the parallel option, for now, I don't think it's of high importance, but I'll add it to my to-do list 🙂

Thanks again!

gsherwood added Status: awaiting feedback Type: question labels Nov 5, 2018

dingo-d closed this as completed Nov 5, 2018

gsherwood removed the Status: awaiting feedback label Nov 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Batch process files in a PHP app? #2207

Batch process files in a PHP app? #2207

dingo-d commented Oct 28, 2018

dingo-d commented Nov 4, 2018

gsherwood commented Nov 5, 2018

dingo-d commented Nov 5, 2018

Batch process files in a PHP app? #2207

Batch process files in a PHP app? #2207

Comments

dingo-d commented Oct 28, 2018

dingo-d commented Nov 4, 2018

gsherwood commented Nov 5, 2018

dingo-d commented Nov 5, 2018