Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conj - undefined keys/values returned when passing objects and maps #284

Closed
philbaker opened this issue Jan 12, 2023 · 1 comment
Closed

Comments

@philbaker
Copy link
Contributor

I've found that conj works as expected for arrays but I'm getting undefined keys/values when passing objects and sets (conj_BANG_ works as expected). Happy to make a PR to fix

conj({name: "George", coat: "Tabby"}, {age: 12})
// { name: 'George', coat: 'Tabby', undefined: undefined }

var conjMap = new Map();
conjMap.set("name", "George");
conjMap.set("coat", "Tabby");
conj(conjMap, {age: 12});

// Map(3) {
//   'name' => 'George',
//   'coat' => 'Tabby',
//   undefined => undefined
// }
@borkdude
Copy link
Member

Sure, PR welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants