nick_password_command server configuration not working

[theRAAPster]

I'm trying to use the nick_password_command server configuration, but when joining the server I'm getting password mismatch errors. I'm running Halloy 2014.14 on OS X 15.1.1, using the onepassword CLI to pull a password from my vault. The command seems to work correctly from my own shell, and for testing purposes I've removed all special characters from the password to make sure there wasn't an issue there.

I couldn't really find detailed logging about what Halloy is pulling in with the command, but looking at the code I think I've found an issue. Should lines 124 and 127 be config.nick_password instead of config.password? My apologies if I'm off here since I'm not a developer, but it didn't look right compared to the previous if statements in that function.

halloy/data/src/server.rs

Lines 123 to 128 in 591b728

	if let Some(nick_pass_command) = &config.nick_password_command {
	if config.password.is_some() {
	return Err(Error::DuplicateNickPassword);
	}
	config.password = Some(read_from_command(nick_pass_command).await?);
	}

[andymandias]

I believe you have correctly diagnosed the problem. If you want to make it into a pull request I'd be happy to review it. Or I can make the pull request if you'd prefer not to make it yourself.