Add option to link to GitHub release #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brocaar
added a commit
to chirpstack/chirpstack-gateway-bridge
that referenced
this pull request
Jun 30, 2016
|
Thanks for your pull request, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, you did great work with your theme! I'm considering to use it for the documentation of some of my themes :-)
One thing that was missing in my opinion was an option to link to a GitHub release instead of the source download. This pull-request implements this option. Please let me know what you think.
If you decide to merge it, would be be able to push a new release to pypi so I can start using it?