Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator does not properly escape back tick character in parameter names. #3

Open
brianmullinsbsd opened this issue Apr 27, 2020 · 0 comments

Comments

@brianmullinsbsd
Copy link

I ran the code generator against the current Swagger defs last Friday. Unfortunately, the /lti/groups/{group_id}/names_and_roles endpoint includes a parameter called rlid. Yes, those are back ticks in the actual parameter name. When the code generator generates the code for this method it produces the following:

if ($Rlid) { $Body["`rlid`"] = $Rlid }

This is not valid as it never is closing the ". The correct code should be:

if ($Rlid) { $Body["``rlid``"] = $Rlid }

This escapes the back tick on both ends and closes the string properly.

I've corrected this by hand in the resulting code. If I get some time this week I'll try to contribute a fix.

Thanks,

Brian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant