Use Map instead of Object for BaseChannel.consumers #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should fix #656 |
|
Thank you @Uzlopak. I've merged into main and will close when I next publish a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a Map instead of an Object for BaseChannel.consumers. It should improve the performance while running in node, as the amount of V8-HiddenClasses will be reduced.
Use Case: If in your implementation alot of consumers get created and canceled, alot of unique V8-HiddenClasses will be created in V8 at runtime.
Information regarding HiddenClasses:
https://v8.dev/blog/slack-tracking