Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for unwrapping FileSystem #1465

Closed
yschimke opened this issue Apr 5, 2024 · 2 comments
Closed

API for unwrapping FileSystem #1465

yschimke opened this issue Apr 5, 2024 · 2 comments

Comments

@yschimke
Copy link
Collaborator

yschimke commented Apr 5, 2024

Maybe unblocked by #1464

But given a FileSystem, I'd like to be able to unwrap it to tell it's real type. Is it FileSystem.SYSTEM under the hood? or a zip file? or resources? or S3?

@swankjesse
Copy link
Collaborator

I don’t want to do this because I think it’ll lead to fragile code in practice.

But I do think we should design a mechanism to add extensions to the file system API so it doesn’t have to be comprehensive always. Perhaps something like OkHttps request tags.

@yschimke yschimke closed this as completed Apr 5, 2024
@swankjesse
Copy link
Collaborator

#1466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants