Parent graphs can be deinited while a child graph is still alive

[holmes]

This crashes the app pretty hard at Graph.swift#280 where let self = self!

[SunnyDayDev]

I have got the same issue. I will try to gather information how to reproduce it. May be you know how do it better?

[holmes]

I haven't looked at this in a long time. If you can repro on a small project we can take another look.

[sebastianv1]

Closing because this issue hasn't received any activity lately, feel free to reopen if it's still an issue.

[SunnyDayDev]

I've created the project which reproduce the issue:
https://github.com/SunnyDayDev/bugreproduce-cleanse

[sebastianv1]

Thanks for the repo project! Will likely take a look this weekend or early next week.

[sebastianv1]

@SunnyDayDev It appears the root of the issue is using a PropertyInjector type as the Root object. Using a UIViewController or UIWindow type for the root does not deinit the graphs.
So in the sample project, in AppComponent.swift, we could instead set the Root type as:
typealias Root = UIWindow.

I'll keep digging how to make the PropertyInjector retain an instance to subgraphs.

[sebastianv1]

PR to resolve (#122). PTAL!