Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration parameters gets ignored if connecting with websockets #119

Open
Gioee opened this issue Nov 5, 2024 · 6 comments
Open

configuration parameters gets ignored if connecting with websockets #119

Gioee opened this issue Nov 5, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@Gioee
Copy link
Member

Gioee commented Nov 5, 2024

Current Behavior

configuration parameters gets ignored if connecting with websockets

Expected Behavior

configuration parameters like maxdata, maxrows, maxrowset, etc. should work

Steps to Reproduce the Problem

  1. Initialize a connection with websockets with optional parameters

Environment

  • Version: 1.308
  • Platform: Mac
  • Node.js Version: v20.12.2
@Gioee Gioee added the bug Something isn't working label Nov 5, 2024
@Gioee
Copy link
Member Author

Gioee commented Nov 5, 2024

This is the method that gets used with tls in the driver getInitializationCommands we should update the driver and the gateway

Copy link
Member

What's the status on this?

@danielebriggi
Copy link
Member

they have the workaround, this bug solves the incoherent behavior of the way to customize the connection parameters

Copy link
Member

jacobprall commented Nov 13, 2024

“Incoherent” is there a fix needed on our side?

@danielebriggi
Copy link
Member

danielebriggi commented Nov 13, 2024

yes, connection should be configurable even when is established via websocket

@Gioee
Copy link
Member Author

Gioee commented Nov 13, 2024

@jacobprall I haven't prioritised it as high because it's not a breaking bug. The user can still set these parameters from the connection string or directly in a query. It's certainly something we have to work on because right now it's not that intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants