Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middle mouse click doesn't close a tab #89

Closed
brunolm opened this issue Feb 10, 2016 · 4 comments
Closed

Middle mouse click doesn't close a tab #89

brunolm opened this issue Feb 10, 2016 · 4 comments

Comments

@brunolm
Copy link

brunolm commented Feb 10, 2016

When I click on a tab with the middle button it doesn't close.

@maxclaus
Copy link
Member

maxclaus commented Mar 4, 2016

The lib we use to build the tabs (https://github.com/reactjs/react-tabs) does not support the event onMouseUp, required to handle "custom" mouse events. So would be required create a pull request to react-tabs including that event before implementing it here. I don't have much interest implementing it because I don't really use it that much. But I would gladly accept a pull request with this feature 😄

@BornaP
Copy link
Member

BornaP commented May 13, 2016

Seems like react-tabs repository is inactive recently (at least admins are), even if someone makes PR it's very unlikely it will be accepted anytime soon.

@maxclaus
Copy link
Member

Well, there are a few options for that:

  • Implement that on react-tabs and use the new branch (in case they don't accept the pull request).
  • Find out another actively maintained react tab component (even better if has that feature already).
  • Instead of use the cursor to close the tab. We could implement a shortcut for that (e.g. Ctrl/Cmd+W) ( I would like this one).

@BornaP
Copy link
Member

BornaP commented May 14, 2016

I agree with third option that you mentioned. We could implement shortcut for that. Tab can be closed on mouse click anyways (by clicking the x button). Secondly, I see that there are some request for implementing support for custom mouse events on react-tabs, so I think it will be implemented eventually and then we can add that to our app easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants