-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Middle mouse click doesn't close a tab #89
Comments
The lib we use to build the tabs (https://github.com/reactjs/react-tabs) does not support the event onMouseUp, required to handle "custom" mouse events. So would be required create a pull request to react-tabs including that event before implementing it here. I don't have much interest implementing it because I don't really use it that much. But I would gladly accept a pull request with this feature 😄 |
Seems like react-tabs repository is inactive recently (at least admins are), even if someone makes PR it's very unlikely it will be accepted anytime soon. |
Well, there are a few options for that:
|
I agree with third option that you mentioned. We could implement shortcut for that. Tab can be closed on mouse click anyways (by clicking the x button). Secondly, I see that there are some request for implementing support for custom mouse events on react-tabs, so I think it will be implemented eventually and then we can add that to our app easily. |
When I click on a tab with the middle button it doesn't close.
The text was updated successfully, but these errors were encountered: