Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues #180

Closed
ghedwards opened this issue Jun 1, 2016 · 9 comments
Closed

Performance issues #180

ghedwards opened this issue Jun 1, 2016 · 9 comments

Comments

@ghedwards
Copy link

Performance issues / comments

  • Query results view with large column set seems to perform badly, I've experimented with react-virtualized and slickgrid. Slickgrid seems to perform the best.
  • Tables tree causes query editor to be quite laggy when there are a lot of tables.
@BornaP
Copy link
Member

BornaP commented Jun 1, 2016

Thanks for the feedback @ghedwards ! We are aware of the first point you made. Regarding the second one, could you explain a bit more, how much tables do you have? Do you find it laggy because of live auto complete? Because I did not find it to be laggy on databases with around 130 tables. (without using auto complete feature).

@maxcnunes
Copy link
Member

I have replaced the vanila HTML table with fixed-data-table. I have not published yet because the build on CI is not working properly due http://stackoverflow.com/a/37559463/1050818. In the next release it should present a better performance.

@ghedwards
Copy link
Author

fixed-data-table seems to have performance issues as well and the project seems to be abandoned and not compatible with new versions of React? Slick grid is ok, but seems too to be a bit of a dead end, I've started looking at / coding https://bvaughn.github.io/react-virtualized/ as a replacement.

@ghedwards
Copy link
Author

1045 tables.. no further comment about the tables issue for now..

@maxcnunes
Copy link
Member

Not sure about the performance issues with fixed-data-table. But that is really not actively maintained over the last months. But what I have looked in react-virtualized I could not find support for grid with a header rows. That is why at the end I have used fixed-data-table.
Could wait until the next release to check if the performance has improved?

@ghedwards
Copy link
Author

100+ rows, 50+ columns.. scroll is laggy and slow. Running straight from master.

@maxcnunes
Copy link
Member

😢 Sorry, but I have just replaced the vanilla HTML table with fixed-data-table. I'm not really in the mood right now to rewrite it again with another library. Although a PR would be gladly accepted 😄

@ghedwards
Copy link
Author

Done, just need to clean up the code a little and make it look a bit nicer. Might have a PR in the next few hours or so.
screen shot 2016-06-03 at 7 58 30 am

@maxcnunes
Copy link
Member

Closed on 678f742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants