add execlastid implementation for mysql #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to the node-pg issue, node-pg does not return last insert id, so can we just throw error in this case? |
kyleconroy
requested changes
Mar 3, 2024
src/app.ts
Outdated
| @@ -77,10 +83,10 @@ function createNodeGenerator(driver?: string): Driver { | |||
| return mysql2; | |||
| } | |||
| case "pg": { | |||
| return pg; | |||
| return pg as any; | |||
There was a problem hiding this comment.
Instead of marking this as any, add a execlastidDecl method to the pg and postgres drivers that raise an error.
There was a problem hiding this comment.
thanks, fixed!: 2398fb0 (#13)
src/drivers/mysql2.ts
Outdated
Comment on lines
181
to
185
| factory.createImportSpecifier( | ||
| false, | ||
| undefined, | ||
| factory.createIdentifier("ResultSetHeader") | ||
| ), |
There was a problem hiding this comment.
We should only import this if there is a execlastid query for the given file.
There was a problem hiding this comment.
fixed: 8d3fcaf (#13)
|
@kyleconroy Hi, thanks for the review. I have addressed your change requests. Please take a look 🙏 |
|
I just pushed some changes to fix the build, can you rebase on main? |
|
@kyleconroy rebase done. |
kyleconroy
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #12
Added MySQL implementation of
:execlastidannotationNeeds some guide for other dialects if I have to cover all dialects to merge this.