Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Replace setup.py package name by pywinpty #19

Merged
merged 1 commit into from
Jun 21, 2017
Merged

PR: Replace setup.py package name by pywinpty #19

merged 1 commit into from
Jun 21, 2017

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Jun 21, 2017

Fixes #18

@andfoy andfoy added this to the v0.1 milestone Jun 21, 2017
@andfoy andfoy self-assigned this Jun 21, 2017
@andfoy andfoy merged commit 8c8717a into andfoy:master Jun 21, 2017
@andfoy andfoy deleted the rename_package branch June 21, 2017 20:54
@goanpeca
Copy link
Contributor

@ccordoba12 I did not understand you show pyzmq and zmq as an example? but you agree with the change or not?

@goanpeca
Copy link
Contributor

I dont undertsand... the pypi package is pywinptyy but the setup was wrong?/?

@andfoy
Copy link
Owner Author

andfoy commented Jun 21, 2017

Yes, I actually forgot to send these changes to upstream

@goanpeca
Copy link
Contributor

ok

@ccordoba12
Copy link
Contributor

The Python package name was wrong but the module name is right.

See: https://github.com/zeromq/pyzmq

@goanpeca
Copy link
Contributor

ok

@ccordoba12
Copy link
Contributor

@andfoy, don't forget to remove winpty from PyPi.

@goanpeca
Copy link
Contributor

That is what I was saying... @andfoy uploaded it correctly...
https://pypi.python.org/pypi/pywinpty

There was never a https://pypi.python.org/pypi/winpty package... I think he forgot to make a PR. That is the reason for making PRs as opposed to working directly on branches ;-)

@ccordoba12
Copy link
Contributor

What? Very confusing!! @andfoy, please be more careful for next time!

@andfoy
Copy link
Owner Author

andfoy commented Jun 21, 2017

Sorry, when I uploaded those wheels the changes were made locally and never got to be even on my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants