-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Replace setup.py package name by pywinpty #19
Conversation
@ccordoba12 I did not understand you show pyzmq and zmq as an example? but you agree with the change or not? |
I dont undertsand... the pypi package is pywinptyy but the setup was wrong?/? |
Yes, I actually forgot to send these changes to upstream |
ok |
The Python package name was wrong but the module name is right. |
ok |
@andfoy, don't forget to remove |
That is what I was saying... @andfoy uploaded it correctly... There was never a https://pypi.python.org/pypi/winpty package... I think he forgot to make a PR. That is the reason for making PRs as opposed to working directly on branches ;-) |
What? Very confusing!! @andfoy, please be more careful for next time! |
Sorry, when I uploaded those wheels the changes were made locally and never got to be even on my fork. |
Fixes #18