PR: Fix for access violation error

[axil]

Fixes #108.

[ccordoba12]

Thanks a lot for this @axil! Are you able to start terminals in the Jupyter notebook with this change?

[axil]

Not sure what you mean by terminals in Jupyter. As for ipython kernels - yes, it starts them. But it did so without the patch as well.

In the previous issue #59 with the similar symptoms they had troubles with terminal in spyder. I didn't check it out yet. Is it what you're asking about?

I'm on Windows 7 64bit btw.

[blink1073]

I can confirm this change allows me to launch terminals from Jupyter on Windows 7, thanks @axil!

[ccordoba12]

Thanks @blink1073 for helping us to test that!

[axil]

Oh, ok. Got it. Looks like a new feature on Windows. Yes, works for me, too.

[wsvma]

Thanks for the fix! Sorry for a newbie question. I installed pywinpty via pip. When does a fix like this typically gets propagated so that the fix can be picked up via pip --upgrade?

[wsvma]

Nevermind my question. I figured it's just whenever next release (0.5.4) is made.

[axil]

@wsvma I see the following variants:

1. You can update the file manually, it works, but sort of considered bad practice. That's what I would do if I were you.
2. The developers can create a pre-release ending with something like "dev" to be installed with pip install --pre
3. You can wait for 0.5.4.

[ccordoba12]

We'll have other of couple simple issues to solve, then we'll release 0.5.4 (next week at most).

[wsvma]

Thanks @axil @ccordoba12