Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Festivities #44

Open
sabas opened this issue Apr 17, 2013 · 4 comments
Open

Festivities #44

sabas opened this issue Apr 17, 2013 · 4 comments
Milestone

Comments

@sabas
Copy link
Collaborator

sabas commented Apr 17, 2013

Different color for days which are:
-national / local festivities
-other days off

@sproctor
Copy link
Owner

sproctor commented May 8, 2013

We could expand categories to cover this issue. Maybe have full day events with categories change the background for the entire day. Or add another category attribute that does it.

@sabas
Copy link
Collaborator Author

sabas commented May 8, 2013

"change the background for the entire day" <- what about css classes? and some definition for rules to apply them (if festivity add .festivity class to the div)

@sproctor
Copy link
Owner

sproctor commented May 8, 2013

The same logic applies for classes as it does for any kind of style. For something programmatic like this, it's easier to add the style to each place it's to be applied. I'm not sure that we want users to have too much control over the CSS as it opens up a path to XSS and similar attacks.

@madahmani
Copy link

The idea is very much interesting and a simple class, similar to Twitter Bootstrap styles may be applied. The user will then have the possibility of assigning a color to each festivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants