Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up browser creation & destruction #14

Closed
jfinkhaeuser opened this issue Apr 23, 2015 · 3 comments
Closed

Clean up browser creation & destruction #14

jfinkhaeuser opened this issue Apr 23, 2015 · 3 comments
Milestone

Comments

@jfinkhaeuser
Copy link
Contributor

  • Check defaults when using browser.create. It currently uses configuration defaults, but IMHO should use the same configuration as when using browser directly, with the ability to override.
  • Ensure browsers created by browser.create also get destroyed.
@jfinkhaeuser
Copy link
Contributor Author

Mostly fixed in (upcoming) 0.7 release. Review of interest.

@barzilay barzilay added this to the Version 1 milestone Mar 20, 2017
@barzilay
Copy link
Contributor

Fixed in ll 1.0. Closing after end is not possible because connection to the browser is already lost. Closing happens just before that happens.

@sjieg
Copy link
Contributor

sjieg commented Mar 20, 2017

# Making sure all browsers are gracefully closed when the exit event is triggered.
at_exit { LapisLazuli::Browser::close_all 'exit event trigger' }

this piece of code ensured a positive destruction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants