From 9efafed57bbf2f0769c1ab7f92041f586c7480b1 Mon Sep 17 00:00:00 2001 From: Narcis Gemene <7252787+narcis96@users.noreply.github.com> Date: Wed, 25 Sep 2024 01:55:02 +0300 Subject: [PATCH] jaegerreceiver: migrate to latest semconv version (#35237) Description: The version of semconv is upgraded from to v1.6.1 to v1.27.0 The semconv attributes' value have been compared using [go-otel-semconv-comparator](https://github.com/narcis96/go-otel-semconv-comparator) resulting in relevant 0 diffs. Link to tracking Issue: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/22095 Testing: Tests passed --- receiver/jaegerreceiver/jaeger_agent_test.go | 2 +- receiver/jaegerreceiver/trace_receiver_test.go | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/receiver/jaegerreceiver/jaeger_agent_test.go b/receiver/jaegerreceiver/jaeger_agent_test.go index 55da7eed2aad..93fa35c85888 100644 --- a/receiver/jaegerreceiver/jaeger_agent_test.go +++ b/receiver/jaegerreceiver/jaeger_agent_test.go @@ -25,7 +25,7 @@ import ( "go.opentelemetry.io/collector/consumer/consumertest" "go.opentelemetry.io/collector/pdata/ptrace" "go.opentelemetry.io/collector/receiver/receivertest" - conventions "go.opentelemetry.io/collector/semconv/v1.6.1" + conventions "go.opentelemetry.io/collector/semconv/v1.27.0" "google.golang.org/grpc" "github.com/open-telemetry/opentelemetry-collector-contrib/internal/common/testutil" diff --git a/receiver/jaegerreceiver/trace_receiver_test.go b/receiver/jaegerreceiver/trace_receiver_test.go index d30a427a9168..c3571fb59f8c 100644 --- a/receiver/jaegerreceiver/trace_receiver_test.go +++ b/receiver/jaegerreceiver/trace_receiver_test.go @@ -32,7 +32,7 @@ import ( "go.opentelemetry.io/collector/pdata/pcommon" "go.opentelemetry.io/collector/pdata/ptrace" "go.opentelemetry.io/collector/receiver/receivertest" - conventions "go.opentelemetry.io/collector/semconv/v1.6.1" + conventions "go.opentelemetry.io/collector/semconv/v1.27.0" "google.golang.org/grpc" "google.golang.org/grpc/credentials" "google.golang.org/grpc/credentials/insecure" @@ -306,8 +306,8 @@ func grpcFixture(t *testing.T, t1 time.Time, d1, d2 time.Duration) *api_v2.PostS StartTime: t1, Duration: d1, Tags: []model.KeyValue{ - model.String(conventions.OtelStatusDescription, "Stale indices"), - model.Int64(conventions.OtelStatusCode, int64(ptrace.StatusCodeError)), + model.String(conventions.AttributeOTelStatusDescription, "Stale indices"), + model.Int64(conventions.AttributeOTelStatusCode, int64(ptrace.StatusCodeError)), model.Bool("error", true), }, References: []model.SpanRef{ @@ -325,8 +325,8 @@ func grpcFixture(t *testing.T, t1 time.Time, d1, d2 time.Duration) *api_v2.PostS StartTime: t1.Add(d1), Duration: d2, Tags: []model.KeyValue{ - model.String(conventions.OtelStatusDescription, "Frontend crash"), - model.Int64(conventions.OtelStatusCode, int64(ptrace.StatusCodeError)), + model.String(conventions.AttributeOTelStatusDescription, "Frontend crash"), + model.Int64(conventions.AttributeOTelStatusCode, int64(ptrace.StatusCodeError)), model.Bool("error", true), }, },