Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct syntax highlighting for JS files goes away after computing symbols #993

Closed
martinlippert opened this issue Mar 8, 2023 · 2 comments
Labels
for: eclipse something that is specific for Eclipse type: bug

Comments

@martinlippert
Copy link
Member

As discussed here: #702 (comment), the correct syntax highlighting of JS files seems to go away as soon as the symbols got computed for a JS file.

Detailed steps how to reproduce this are here: #702 (comment)

It looks like the semantic highlighting of LSP4E seems to be involved here, but we need to investigate this. It works fine in Eclipse JEE 2023-03 builds as well as the latest WWD releases, so maybe related to the LSP4E snapshot version that we include in STS builds.

@martinlippert martinlippert added type: bug for: eclipse something that is specific for Eclipse labels Mar 8, 2023
@martinlippert martinlippert added this to the 4.18.0.RELEASE milestone Mar 8, 2023
@martinlippert
Copy link
Member Author

Ok, I think this is indeed related to semantic highlighting done by LSP4E, so filed the issue over here: eclipse-lsp4e/lsp4e#537 - closing this one here as a duplicate now.

@martinlippert martinlippert closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2023
@martinlippert
Copy link
Member Author

This is now fixed the latest lsp4e snapshot builds, so the next STS 4.18.0 CI build will pick that up automatically and the next release (scheduled for next week) should include this fix as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse type: bug
Projects
None yet
Development

No branches or pull requests

1 participant