Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update generated parser for Java properties with latest ANTLR runtime version #946

Closed
martinlippert opened this issue Jan 9, 2023 · 3 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: property-editing-support type: enhancement

Comments

@martinlippert
Copy link
Member

This error message appears in the log when opening an application.properties file:
ANTLR Tool version 4.5.3 used for code generation does not match the current runtime version 4.9.3

I think we need to re-generate the parser for Java properties with the ANTLR version that we use in the dependencies, which seems to be 4.9.3.

@martinlippert martinlippert added type: enhancement theme: property-editing-support for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode labels Jan 9, 2023
@martinlippert martinlippert added this to the 4.17.2.RELEASE milestone Jan 9, 2023
@BoykoAlex
Copy link
Contributor

@martinlippert I had an idea of switching to OR Properties parser and AST.

@martinlippert
Copy link
Member Author

What will be the difference? I haven't looked into the details yet, but re-using a properties parser sounds like a good idea instead of keeping our own up-to-date. But we should make sure that the switch to a new parser doesn't affect the coding experience here. I have things like fault-tolerant parsing in mind here. WDYT?

@BoykoAlex
Copy link
Contributor

Fixed with 39de9aa
Rewrite parser rather than our own is moved to: #949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: property-editing-support type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants