Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add var_sources to Concourse schema #944

Closed
ThibaultDelaune-pro opened this issue Jan 9, 2023 · 1 comment
Closed

Add var_sources to Concourse schema #944

ThibaultDelaune-pro opened this issue Jan 9, 2023 · 1 comment
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: concourse-support type: enhancement

Comments

@ThibaultDelaune-pro
Copy link

ThibaultDelaune-pro commented Jan 9, 2023

Describe the bug

Concourse CI Pipeline Editor VSCode extensions are falsely reporting a problem with var_sources.

Error message:

Unknown property 'var_sources' for type 'Pipeline' vscode-concourse(YamlSchemaProblem)

This request is really similar to #942, maybe you could combine them...

To Reproduce

---
var_sources:
- name: global_vars
  type: dummy
  config:
    vars:
      pipeline-path: pipelines/example.yml

resources:
  - name: concourse
    type: git
    icon: github
    source:
      uri: https://github.com/concourse/concourse.git
      branch: main

jobs:
  - name: example
    plan:
      - get: concourse
      - set_pipeline: examples
        file: concourse/((global_vars:pipeline-path))

Fix

Please add var_sources to Concourse schema.

cf. https://concourse-ci.org/vars.html#var-sources

@martinlippert martinlippert added for: eclipse something that is specific for Eclipse theme: concourse-support for: vscode something that is specific for VSCode and removed status: waiting-for-triage labels Jan 9, 2023
@martinlippert martinlippert added this to the 4.17.2.RELEASE milestone Jan 9, 2023
@BoykoAlex BoykoAlex self-assigned this Jan 18, 2023
@BoykoAlex
Copy link
Contributor

Fixed with 1812584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: concourse-support type: enhancement
Projects
None yet
Development

No branches or pull requests

3 participants