Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactoring] [validation] final polishing work #911

Closed
8 tasks done
martinlippert opened this issue Dec 1, 2022 · 1 comment
Closed
8 tasks done

[refactoring] [validation] final polishing work #911

martinlippert opened this issue Dec 1, 2022 · 1 comment
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring type: enhancement

Comments

@martinlippert
Copy link
Member

martinlippert commented Dec 1, 2022

Version validations:

  • default severity for patch version validation: warning
  • default severity for minor version validation: info
  • default severity for major version validation: ignore

Reconciling (open rewrite):

  • default for reconciling: disabled
  • add popup to enable reconciling (make people aware of this) (if possible)

Quick fixes for version upgrades:

  • distinguish between simple upgrades (just the parent version in the pom for newer patch versions) and complex upgrades, so that users can directly see what will happen when executing those quick-fixes
  • add description for the quick-fixes, so that users can see what the quick-fix means

Refactorings dialog:

  • distinguish between "convert from one version to the other" recipes from "applying certain best practices", grouping them together

The last piece is probably the most difficult one to get right, since I am not sure yet on what the right structure for this is. At the moment this is really just a random collection of stuff in the dialog and the title of the action on the context-menu is engineering driven. I really would like to change that.

One option could be to have one context menu item: Upgrade Project to Newer Spring Boot Version, which them shows only a list of items saying Convert from Spring Boot 2.6 to 2.7, Convert from Spring Boot 2.7 to 3.0, etc. All with the same names and the same structure, so that it is easy to see which one converts from what version to what other version. Then, we could have another context-menu, say Additional Project-Wide Refactorings (based on OpenRewrite)..., that then has another list of recipes...

Or we keep one dialog, but group the recipes in sections: One for Spring Boot version upgrades, one for other upgrades, one for best practices, etc. But I think the Spring Boot version upgrade topic is front and center, so it deserves its own context menu item.

@martinlippert martinlippert added type: enhancement for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring labels Dec 1, 2022
@martinlippert martinlippert added this to the 4.17.0.RELEASE milestone Dec 1, 2022
@BoykoAlex
Copy link
Contributor

Should be fixed with 88b5914 and c262b5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants