Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure VSCode shows an error message when running on a JDK <17 #903

Closed
martinlippert opened this issue Nov 23, 2022 · 3 comments
Closed

make sure VSCode shows an error message when running on a JDK <17 #903

martinlippert opened this issue Nov 23, 2022 · 3 comments
Assignees
@BoykoAlex
Labels
for: vscode something that is specific for VSCode type: enhancement type: install-issue
Milestone
4.17.0.RELEASE

Comments

@martinlippert
Copy link
Member

We need to make sure that the VSCode extension double checks the version of the JDK is runs the language server on and reports anything that is <17 to the user as a wrong setting.

See the comment here: #893 (comment)
@martinlippert martinlippert added this to the 4.17.0.RELEASE milestone Nov 23, 2022
@martinlippert martinlippert mentioned this issue Nov 23, 2022
Closed
@BoykoAlex
Copy link
Contributor

@martinlippert Is this for all spring extensions or just the Spring Boot extension?

@martinlippert
Copy link
Member Author

I think it makes sense to have this check for all extensions.

@BoykoAlex
Copy link
Contributor

Fixed with 06dd3a8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoykoAlex BoykoAlex

Labels
for: vscode something that is specific for VSCode type: enhancement type: install-issue
Projects
None yet
Milestone
4.17.0.RELEASE
Development

No branches or pull requests
2 participants
@martinlippert @BoykoAlex