Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactoring] reduce size of execute rewrite recipes messages #897

Closed
martinlippert opened this issue Nov 21, 2022 · 2 comments
Closed

[refactoring] reduce size of execute rewrite recipes messages #897

martinlippert opened this issue Nov 21, 2022 · 2 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring type: enhancement

Comments

@martinlippert
Copy link
Member

The message for the command sts/rewrite/execute contains lots of data and has a size of about 500Kb (in my tests). This doesn't seem to be reasonable and we should reduce the size down to the data that is really needed to identify the selected recipes and their params (as a first guess).

@BoykoAlex
Copy link
Contributor

The sts/rewrite/list needs improvements in this area as well. Likely we need to flatten the recipe tree such that when navigating inside the recipe we'd load more data for sub-recipes rather than load everything at once.
There is going to be quite a bit of work. Size of the recipe descriptor json has grown thus we'd need to address this rather soon.

@BoykoAlex BoykoAlex modified the milestones: Backlog, 4.21.1.RELEASE Dec 19, 2023
@BoykoAlex
Copy link
Contributor

Should be fixed with d6ff60a
Instead of loading. all recipes and sub-recipes lazy load sub-recipes on demand. Instead of sending recipe descriptors to instatiate recipes on the LS side send selected recipes json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants