Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VScode incorrectly suggests removing @Autowired annotation from methods #787

Closed
jeffduhamel opened this issue Jun 15, 2022 · 3 comments
Closed

VScode incorrectly suggests removing @Autowired annotation from methods #787

jeffduhamel opened this issue Jun 15, 2022 · 3 comments
Assignees
@BoykoAlex
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode status: assigned status: in-progress theme: refactoring type: bug
Milestone
4.15.1.RELEASE

Comments

@jeffduhamel
Copy link

Describe the bug
Following the most recent update, VScode quick fix and Problem view are incorrectly suggesting removing @Autowired annotation from autowired methods. The issue is flagged as JAVA_AUTOWIRED_CONSTRUCTOR, but these are not constructors.

image
@BoykoAlex
Copy link
Contributor

Great, thanks for reporting this. Will be adjusted.

@BoykoAlex BoykoAlex self-assigned this Jun 16, 2022
@martinlippert martinlippert added this to the 4.15.1.RELEASE milestone Jun 16, 2022
@martinlippert martinlippert added status: assigned for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: refactoring status: in-progress and removed status: waiting-for-triage labels Jun 16, 2022
@BoykoAlex
Copy link
Contributor

The fix is 382d0bb.
We'll be creating another release in a few days from now to include this fix. Once the RC is tested I'll mark it as fixed.

@BoykoAlex
Copy link
Contributor

@jeffduhamel here is the RC that has it fixed: https://s3.us-west-1.amazonaws.com/s3-test.spring.io/sts4/vscode-extensions/snapshots/vscode-spring-boot-1.36.0-RC.1.vsix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BoykoAlex BoykoAlex

Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode status: assigned status: in-progress theme: refactoring type: bug
Projects
None yet
Milestone
4.15.1.RELEASE
Development

No branches or pull requests
3 participants
@martinlippert @BoykoAlex @jeffduhamel