Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause / Resume for docker boot dash malfunctions #783

Closed
kdvolder opened this issue Jun 13, 2022 · 1 comment
Closed

Pause / Resume for docker boot dash malfunctions #783

kdvolder opened this issue Jun 13, 2022 · 1 comment
Assignees
Labels
for: eclipse something that is specific for Eclipse theme: boot-dashboard type: bug

Comments

@kdvolder
Copy link
Member

Describe the bug

When we 'resume' a paused docker process via the context menu on the top-level node (i.e. the node representing the app rather than the container) it misbehaves:

  • If container is running in 'normal' mode (i.e. not 'debug' mode) and then paused...
    => the app node neverteless shows it as 'REsume debugging)'
    => invoking that function actually does connect the debugger, but it doesn't actually 'resume' but rather starts a new / separate container instead.

  • if container is running in debug and then paused...
    => the menu correctly shows 'resume debugging'
    => Selecting the menu doesn't actually do anything however.

To Reproduce

  • Deploy a new boot app to docker
  • pause it
  • try resuming it

You can observe all the above described behaviors.

@kdvolder
Copy link
Member Author

Debugged a bit. A one line fix, seems like it was a copy-pasting error. The logic for not making it visible on app nodes was only present in the 'Resume (Running)' action but it really should apply to both 'Resume (Running)' and 'Resume (debugging)'. The original intent when this was implemented seems to have been to only have the menu on nodes that can be direclty 'paused' (i.e. only nodes that have 'pause' will also have a 'resume (XXX)'.

So it was a simpe one line code fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse theme: boot-dashboard type: bug
Projects
None yet
Development

No branches or pull requests

2 participants