Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring rename support for SpEL literals that references other code #521

Open
MahatmaFatalError opened this issue Aug 10, 2020 · 0 comments

Comments

@MahatmaFatalError
Copy link

MahatmaFatalError commented Aug 10, 2020

Follow up of #475

Considering this situation:

@CacheEvict(key = "#customer.customerId")
public void insert(Customer customer) {
	//some logic
}

Then assume to refactor rename the field customerId of the Customer class to e.g. just id. Since the cache key String literal is not considered by the refactoring action it is hard to notice that the @CacheEvict does not work anymore as expected.

Similarly, renaming a method parameter does not take the String literal into account
grafik

So it would be great if the refactor rename action also considers SpEL literals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants