Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"class" snippet is not available #192

Closed
kawnnor opened this issue Jan 30, 2019 · 7 comments
Closed

"class" snippet is not available #192

kawnnor opened this issue Jan 30, 2019 · 7 comments
Milestone

Comments

@kawnnor
Copy link

kawnnor commented Jan 30, 2019

Spring Boot Tools Extension 1.3.0 caused the class / interface snippets and package / public keywords of "Language Support for Java by Red Hat" extension to be unusable. Rolled back to 1.2.0, everything works fine.

@kdvolder
Copy link
Member

Can you please explain what exactly is not working for you? I simply can't work it out from your description.

Here's what I tried.

  • I started with a fresh vscode without any extensions.
  • Installed just the "Language Support for Java(TM) by Red Hat" extension.
  • I opened a random simple Java project I had sitting around
  • I created a new empty Java file called "NewClass.java" in my source folder
  • I press CTRL-space. I get nothing, no content assist no snippets.

So how do I get to these snippets you are referring to exactly? How are they supposed to work? And how does the behavior you expected as 'correct' differ from the behavior when Spring Boot Extensions are installed?

We'd like to get to the bottom of this. But I'm afraid that unless you explain precisely what you think is broken then this will be rather impossible.

@spring-projects-issues
Copy link

(comment in Pivotal Tracker added by Kris De Volder:)

Dropping this item to the back of the backlog since I can't reproduce it.

@kdvolder
Copy link
Member

Gave it another try. Looks like I made a mistake the first time around. My new file wasn't actually a '.java' file. I forgot to add the '.java' extension.

So the steps from above seem to work to get the interface and class snippets to show up (i.e. empty .java file, press CTRL-space).

I then installed Spring boot tools 1.3.0 and tried the same steps again. It still works for me.

So... I think I did figure out which snippets we are talking about and how to invoke them but they seem to work for me just fine, with and without Spring Boot Tools 1.3.0 installed.

Cllosing this ticket as 'cannot reproduce'.

If you can add precise steps, we can re-open the ticket and I'll give it another try. But as far as I can tell right now it is working fine.

That probably means we are missing some details on what are the exact steps, or circumstances that cause this to break. Or perhaps you made silly mistake (much like I did when I tried first time to reproduce it :-)

@kawnnor
Copy link
Author

kawnnor commented Feb 1, 2019

@kdvolder
Demo Video - https://d.pr/v/QXZBPp

@martinlippert
Copy link
Member

Maybe there is a relationship between this and #193 ?

@kdvolder
Copy link
Member

kdvolder commented Feb 1, 2019

I think @martinlippert is onto something. Not totally sure, but in the video it looks like you are expecting completions to show 'as you type'. When I was trying it, I was explicitly pressing CTRL-space to trigger them.

@kawnnor can you try installing spring-boot-tools 1.4 snapshot build. You can get it here: http://dist.springsource.com/snapshot/STS4/nightly-distributions.html

@kawnnor
Copy link
Author

kawnnor commented Feb 2, 2019

@kdvolder spring-boot-tools 1.4.0-201902011927 works fine. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants