Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpEL Syntax Highlighting #1234

Closed
BoykoAlex opened this issue Apr 18, 2024 · 6 comments
Closed

SpEL Syntax Highlighting #1234

BoykoAlex opened this issue Apr 18, 2024 · 6 comments
Assignees
Labels
for: vscode something that is specific for VSCode theme: spel-support type: enhancement

Comments

@BoykoAlex
Copy link
Contributor

BoykoAlex commented Apr 18, 2024

SpEL syntax highlighting via LSP semantic tokens inside:

  • Java annotations
  • Inside JPQL queries
@BoykoAlex BoykoAlex self-assigned this Apr 18, 2024
@BoykoAlex BoykoAlex added this to the 4.22.1.RELEASE milestone Apr 18, 2024
@martinlippert martinlippert added theme: spel-support for: vscode something that is specific for VSCode and removed status: waiting-for-triage labels Apr 18, 2024
@martinlippert martinlippert changed the title SPEL Syntax Highlighting SpEL Syntax Highlighting Apr 18, 2024
@BoykoAlex
Copy link
Contributor Author

I took the Antlr SPEL parser that was kept from the past and it doesn't seem to parse all valid SPEL. For example someBean.someProperty != null ? someBean.someProperty : 'default' also i didn't see matches keyword in the parser hence I suspect that this won't parse either: '100' matches '\\d+'.
Definitely won't be completed for 4.23.0

@BoykoAlex
Copy link
Contributor Author

Fixed with 15f20b6 exceptfor embedded inside SQL queries which is be addressed via #1270

@MahatmaFatalError
Copy link

@BoykoAlex could you please share a sample screenshot how the syntax highlighting looks like for SpEL? I am not sure if it works for me

@BoykoAlex
Copy link
Contributor Author

BoykoAlex commented Aug 5, 2024

Screenshot 2024-08-05 at 10 49 40

Something like the above.

What are you getting @MahatmaFatalError ? Send a screenshot and a snippet please. (Note: no syntax highlighting in Eclipse yet)

@MahatmaFatalError
Copy link

ah ok, only VSCode, the release notes https://github.com/spring-projects/sts4/releases/tag/4.24.0.RELEASE lead to the impression that it is generally available, i.e. including eclipse

@martinlippert
Copy link
Member

martinlippert commented Aug 12, 2024

@MahatmaFatalError Totally agree, the release notes should be more precise about this. I added a section in the release notes. The support for Eclipse is tracked here #1235. Thanks again for pointing us at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: vscode something that is specific for VSCode theme: spel-support type: enhancement
Projects
None yet
Development

No branches or pull requests

3 participants