Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add public PGP key to installation as trusted key #1088

Closed
martinlippert opened this issue Jul 27, 2023 · 3 comments
Closed

add public PGP key to installation as trusted key #1088

martinlippert opened this issue Jul 27, 2023 · 3 comments
Assignees
Labels
for: eclipse something that is specific for Eclipse type: enhancement type: install-issue

Comments

@martinlippert
Copy link
Member

We should add our public PGP key to the product as a trusted key, so that users don't get prompted to manually trust the key when they update existing installations.

An example for this is:
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/73905d3ea1a8dbf42f17806ac0ccc41fec7df8d6/eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/pom.xml#L299

@BoykoAlex
Copy link
Contributor

@martinlippert don't think the example above accomplishes what we'd like to achieve... I've tried adding the code in the pom many times in different forms and it had no effect.

If we want to contribute a trusted key than I think it should be done via extension point like here #1089.

However, this still doesn't achieve the desired effect since there is laso Bouncy Castle key that users need to trust and then another one unnamed and then there are also Trusted Authorities for dist.springsource.com and downloads.springsource.com which is some Cloudflare thing which user is prompted to trust as well. I didn't figure out how to contribute authorities... maybe this is via jvm keytool...

In the preferences in the search box type "pgp" should show "Install/Update" -> "Trust" page where you could what are the trusted key and authorities.

Anyway, I don't think i see a solution that frees the user from dealing with the Trust prompt dialog yet... Don't think we are ready to fix this fully.

@BoykoAlex BoykoAlex modified the milestones: 4.19.1.RELEASE, Backlog Aug 1, 2023
@martinlippert
Copy link
Member Author

Let's contribute the public Spring key for the moment. We can add additional items here in the future and create separate issues for that.

@martinlippert martinlippert modified the milestones: Backlog, 4.19.1.RELEASE Aug 1, 2023
@BoykoAlex
Copy link
Contributor

PGP key contribution is added with 0b848aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: eclipse something that is specific for Eclipse type: enhancement type: install-issue
Projects
None yet
Development

No branches or pull requests

2 participants