Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate .and() and non lambda DSL methods #13010

Conversation

marcusdacoregio
Copy link
Contributor

No description provided.

@marcusdacoregio marcusdacoregio added in: config An issue in spring-security-config type: task A general task labels Apr 13, 2023
@marcusdacoregio marcusdacoregio self-assigned this Apr 13, 2023
Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. Currently the deprecation notices only state that it is for removal. Please ensure all the deprecation notices include that it will be removed in 7.0. I provided one comment on the documentation as well. After these changes are made, please feel free to merge.

[[preparing]]
= Preparing for 7.0

While Spring Security 7.0 is a bit far away, it is important to start preparing for it now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change this to state that a date for Spring Security 7.0 has not been set

@marcusdacoregio marcusdacoregio force-pushed the gh-12629-deprecate-httpsecurity-and branch from 74ce360 to 59a02cf Compare April 14, 2023 17:59
@marcusdacoregio marcusdacoregio force-pushed the gh-12629-deprecate-httpsecurity-and branch from 59a02cf to 29153a3 Compare April 14, 2023 18:41
@marcusdacoregio marcusdacoregio added this to the 6.1.0-RC1 milestone Apr 14, 2023
@marcusdacoregio marcusdacoregio added the status: duplicate A duplicate of another issue label Apr 14, 2023
@marcusdacoregio marcusdacoregio merged commit 82a1492 into spring-projects:main Apr 14, 2023
@marcusdacoregio marcusdacoregio deleted the gh-12629-deprecate-httpsecurity-and branch April 14, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants