Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Security Filters Documentation #8167

Closed
asaikali opened this issue Mar 22, 2020 · 1 comment
Closed

Improve Security Filters Documentation #8167

asaikali opened this issue Mar 22, 2020 · 1 comment
Assignees
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Milestone

Comments

@asaikali
Copy link

Documentation at Security Filters leaves a lot of questions unanswered. Suggest that that section be enhanced by answering the following questions.

  • In troubleshooting scenario how to get a list of what the filter chain looks like printed to the log?
  • How to add a custom filter to the filter chain at a specific position?
  • What are some use cases where a custom filter would be needed?
  • Turn the list into a table that provides the name of the filter and a short description of what the filter does.
  • Are all the filters always present even if a specified module is not being used? for example if my app is not using SAML is the Saml2WebSsoAuthenticationFilter still present in the filter chain?
  • Is the filter chain listed in the docs configured by spring security or via spring boot auto configuration?

I believe answering the above questions in this section will make the docs much better.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 22, 2020
@eleftherias eleftherias added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 23, 2020
@rwinch
Copy link
Member

rwinch commented Mar 24, 2020

Thanks for the report @asaikali! Would you be interested in providing a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
Status: Done
Development

No branches or pull requests

5 participants