Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latest "OAuth2AuthorizedClientManager" class is not AOT ready #14094

Closed
meletis opened this issue Nov 4, 2023 · 4 comments
Closed

The latest "OAuth2AuthorizedClientManager" class is not AOT ready #14094

meletis opened this issue Nov 4, 2023 · 4 comments
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Milestone

Comments

@meletis
Copy link

meletis commented Nov 4, 2023

Quoting wilkinsona's comment at spring-projects/spring-boot#38185 (comment):

Thanks for the sample and for trying the RC. This is a regression in Spring Security 6.2, caused by the changes made for #11783. Please open a Spring Security issue.

It looks like spring-projects/spring-boot#38185 is caused by a bug in Spring Security. Since I also came across it in my project, I took the chance to create the ticket here as suggested.

I'm also quoting the sample POC for convenience:

https://github.com/simon-hock/spring-security-aot

@meletis meletis added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Nov 4, 2023
@simon-hock
Copy link

Thanks for posting here @meletis !
I was about to do it !

Have a great day

@sjohnr sjohnr self-assigned this Nov 6, 2023
@sjohnr sjohnr added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 6, 2023
@sjohnr
Copy link
Member

sjohnr commented Nov 6, 2023

Thanks for trying the RC and for the report @meletis! I can confirm that we're using a singleton supplier as I didn't realize that would not work with AOT. We'll take a look right away.

@sjohnr sjohnr moved this to Prioritized in Spring Security Team Nov 6, 2023
@sjohnr sjohnr closed this as completed in 77acaaa Nov 6, 2023
@sjohnr sjohnr moved this from Prioritized to Done in Spring Security Team Nov 6, 2023
@sjohnr
Copy link
Member

sjohnr commented Nov 6, 2023

Thanks again @meletis for the report and @simon-hock for the sample. I have pushed a fix and verified that an AOT build succeeds. Would either of you be able to try out 6.2.0-SNAPSHOT and let me know if it fully resolves the issue for you?

@sjohnr sjohnr added this to the 6.2.0 milestone Nov 6, 2023
@meletis
Copy link
Author

meletis commented Nov 6, 2023

It worked great for me @sjohnr !

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Projects
Archived in project
Development

No branches or pull requests

3 participants