Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultAuthorizationCodeTokenResponseClient.getTokenResponse(OAuth2AuthorizationCodeGrantRequest) can return null #13143

Closed
rwinch opened this issue May 8, 2023 · 0 comments
Closed

DefaultAuthorizationCodeTokenResponseClient.getTokenResponse(OAuth2AuthorizationCodeGrantRequest) can return null #13143

rwinch opened this issue May 8, 2023 · 0 comments
Assignees
@jzheaux
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug
Milestone
5.8.x

Comments

@rwinch
Copy link
Member

rwinch commented May 8, 2023 •
edited
Loading

In some cases DefaultAuthorizationCodeTokenResponseClient.getTokenResponse(OAuth2AuthorizationCodeGrantRequest) can return null. For example, when a redirect is returned the body is empty. This causes a NullPointerException in OidcAuthorizationCodeAuthenticationProvider.

If the response is invalid, I believe we should provide a meaningful error to users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug
Projects
Spring Security Team
Status: Done
Milestone
5.8.x
Development

No branches or pull requests
2 participants
@rwinch @jzheaux