Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observation Spans are not nested correctly in Webflux #12849

Closed
braunsonm opened this issue Mar 8, 2023 · 1 comment
Closed

Observation Spans are not nested correctly in Webflux #12849

braunsonm opened this issue Mar 8, 2023 · 1 comment
Assignees
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Milestone

Comments

@braunsonm
Copy link
Contributor

Describe the bug
The observations that Spring Security provides are not being properly nested with their parent span when running in Webflux mode. This does not affect servlet.

To Reproduce

  1. Run any spring boot application with webflux and spring security to your tracing backend of choice (in my example, Tempo)
  2. Make any HTTP call
  3. Notice the trace spans are not properly nested

WEBFLUX
image

Expected behavior
The spans should be nested as they are in Servlet mode. This becomes hard to read in very large or complicated filter chains across multiple services

SERVLET
image

Sample

There is no need for sample code as your project literally does not need to have any code in it aside from start.spring.io dependencies I listed.

@braunsonm braunsonm added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Mar 8, 2023
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 24, 2023
@jzheaux
Copy link
Contributor

jzheaux commented Mar 24, 2023

Thanks, @braunsonm, for the report. I've scheduled it for our next maintenance release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
Status: Done
Development

No branches or pull requests

2 participants