Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwitchUserFilter should use HttpSessionSecurityContextRepository by default #12834

Closed
marcusdacoregio opened this issue Mar 7, 2023 · 0 comments
Closed

SwitchUserFilter should use HttpSessionSecurityContextRepository by default #12834

marcusdacoregio opened this issue Mar 7, 2023 · 0 comments
Assignees
@marcusdacoregio
Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Milestone
5.7.8

Comments

@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Mar 7, 2023 •
edited
Loading

#12504 fixed the SwitchUserFilter by saving the security context explicitly.

Switching users typically implies a user is logged in and has an authenticated session that needs to change across a period of requests. Therefore, it makes sense to use HttpSessionSecurityContextRepository
@marcusdacoregio marcusdacoregio added in: web An issue in web modules (web, webmvc) type: bug A general bug labels Mar 7, 2023
@marcusdacoregio marcusdacoregio added this to the 5.7.8 milestone Mar 7, 2023
@marcusdacoregio marcusdacoregio self-assigned this Mar 7, 2023
@marcusdacoregio marcusdacoregio mentioned this issue Mar 7, 2023
Closed
@marcusdacoregio marcusdacoregio modified the milestones: 5.7.8, 5.8.3 Mar 7, 2023
@marcusdacoregio marcusdacoregio changed the title SwitchUserFilter should use DelegatingSecurityContextRepository by default SwitchUserFilter should use HttpSessionSecurityContextRepository by default Mar 7, 2023
@marcusdacoregio marcusdacoregio modified the milestones: 5.8.3, 5.7.8 Mar 7, 2023
@marcusdacoregio marcusdacoregio mentioned this issue Mar 7, 2023
Closed
@filiphr filiphr mentioned this issue Jun 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
None yet
Milestone
5.7.8
Development

No branches or pull requests
1 participant
@marcusdacoregio