Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate javadoc text in setRequestHandler method from CsrfWebFilter class #12465

Closed
wldomiciano opened this issue Dec 25, 2022 · 0 comments
Closed
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement

Comments

@wldomiciano
Copy link
Contributor

Expected Behavior

In version 6.0, the default ServerCsrfTokenRequestHandler of the CsrfWebFilter class has changed to XorServerCsrfTokenRequestAttributeHandler and the javadoc of the setRequestHandler method should reflect this change.

Current Behavior

The javadoc of the setRequestHandler method still says that the default is the ServerCsrfTokenRequestAttributeHandler.

Although XorServerCsrfTokenRequestAttributeHandler is a subclass of ServerCsrfTokenRequestAttributeHandler, the behavior is quite different.

Context

In this line, the requestHandler is initialized with a XorServerCsrfTokenRequestAttributeHandler instance.

And in this line the javadoc inform the default ServerCsrfTokenRequestHandler.

@wldomiciano wldomiciano added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Dec 25, 2022
@sjohnr sjohnr added in: web An issue in web modules (web, webmvc) and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 4, 2023
@jzheaux jzheaux closed this as completed in 27b3f4d Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants