Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NimbusJwtClientAuthenticationParametersConverter support Microsoft identity platform. #10897

Closed
chenrujun opened this issue Feb 22, 2022 · 1 comment
Closed

Make NimbusJwtClientAuthenticationParametersConverter support Microsoft identity platform. #10897

chenrujun opened this issue Feb 22, 2022 · 1 comment
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue

Comments

@chenrujun
Copy link
Contributor

Expected Behavior

NimbusJwtClientAuthenticationParametersConverter can be used directly for Microsoft identity platform .

Current Behavior

NimbusJwtClientAuthenticationParametersConverter can not be used directly for Microsoft identity platform .

Context

Reason
I guess it's caused by:

  1. There is no "typ" and "x5t" in the header.
  2. There is no "nbf" in the claim set.

Proposals

  1. Add these fields ("typ", "x5t" and "nbf") in NimbusJwtClientAuthenticationParametersConverter.
  2. Make these fields ("typ", "x5t" and "nbf") configurable in NimbusJwtClientAuthenticationParametersConverter. For example, pass in by constructor.
@chenrujun chenrujun added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Feb 22, 2022
@jgrandja
Copy link
Contributor

@chenrujun This is a duplicate of gh-9852. We'll soon be adding support for customizing claims via gh-9855.

@jgrandja jgrandja self-assigned this Feb 22, 2022
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgrandja @chenrujun