Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure audience of JWT in PRIVATE_KET_JWT client authentication #10530

Closed
iamlothian opened this issue Nov 18, 2021 · 1 comment
Closed

Configure audience of JWT in PRIVATE_KET_JWT client authentication #10530

iamlothian opened this issue Nov 18, 2021 · 1 comment
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement

Comments

@iamlothian
Copy link

Expected Behavior

although rfc7523#section-3 say the token url MAY be used as the aud claim values, it's not required to be this value, some systems expect this to be the issuer url rather than the token endpoint url.

could we provide an override Function<ClientRegistration, String> that extracts the desired value from the registration?

Current Behavior

NimbusJwtClientAuthenticationParametersConverter

JwtClaimsSet.Builder claimsBuilder = JwtClaimsSet.builder()
        .issuer(clientRegistration.getClientId())
        .subject(clientRegistration.getClientId())
        .audience(Collections.singletonList(clientRegistration.getProviderDetails().getTokenUri()))
        .id(UUID.randomUUID().toString())
        .issuedAt(issuedAt)
        .expiresAt(expiresAt);

Context

Integrating with Forgerock as an IDP using PRIVATE_KET_JWT client where the aud claim of the signed jwt is expected to be the issuer url

@iamlothian iamlothian added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Nov 18, 2021
@sjohnr sjohnr added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 22, 2021
@jgrandja
Copy link
Contributor

Closing as duplicate of gh-9855

@jgrandja jgrandja added the status: duplicate A duplicate of another issue label Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants