Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align observation convention with Micrometer best practices #558

Closed
bclozel opened this issue Dec 2, 2022 · 0 comments
Closed

Align observation convention with Micrometer best practices #558

bclozel opened this issue Dec 2, 2022 · 0 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Dec 2, 2022

The current observation contextual names and key values are not in line with the Micrometer guidelines.

We should ensure that contextual names are lowercase like graphql instead of graphQL , otherwise the name of the observation can be normalized by collectors as graph-q-l and this is unfortunate. We should also prefix key values with "graphql.*" for a cleaner namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant