Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RestClient instrumentation unnecessarily calls stop on a closed observation #33346

Closed
snicoll opened this issue Aug 8, 2024 · 1 comment
Closed

RestClient instrumentation unnecessarily calls stop on a closed observation #33346

snicoll opened this issue Aug 8, 2024 · 1 comment
Assignees
@snicoll
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Milestone
6.1.12

Comments

@snicoll
Copy link
Member

snicoll commented Aug 8, 2024

When RestClient instruments reading the response body, it will trigger stop on an exception, which is already handled by closing the ClientHttpResponse. This results on multiple calls to stop.
@snicoll snicoll added type: bug A general bug theme: observability An issue related to observability and tracing labels Aug 8, 2024
@snicoll snicoll added this to the 6.1.12 milestone Aug 8, 2024
@snicoll snicoll self-assigned this Aug 8, 2024
@snicoll snicoll changed the title RestClient instrumentation unecessary call stops on a closde observation RestClient instrumentation unecessary call stops on a closed observation Aug 8, 2024
@snicoll snicoll closed this as completed in 36e84a5 Aug 8, 2024
@snicoll
Copy link
Member Author

snicoll commented Aug 8, 2024

Thanks very much @jonatan-ivanov

@jhoeller jhoeller added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Aug 8, 2024
@jhoeller jhoeller changed the title RestClient instrumentation unecessary call stops on a closed observation RestClient instrumentation unnecessarily calls stop on a closed observation Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Projects
None yet
Milestone
6.1.12
Development

No branches or pull requests
2 participants
@snicoll @jhoeller