Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javadoc of ReactorNettyClientRequestFactory#setExchangeTimeout methods have wrong default value #32419

Closed
KimJejun opened this issue Mar 12, 2024 · 1 comment
Assignees
Labels
type: documentation A documentation task
Milestone

Comments

@KimJejun
Copy link

Affects: 6.1.4


Hi there.

exchageTimeout default value is 5 sec.

But these two lines seem to be misleading.

/**
* Set the timeout for the HTTP exchange in milliseconds.
* <p>Default is 30 seconds.
*/
public void setExchangeTimeout(long exchangeTimeout) {

/**
* Set the timeout for the HTTP exchange.
* <p>Default is 30 seconds.
*/
public void setExchangeTimeout(Duration exchangeTimeout) {

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 12, 2024
@snicoll snicoll added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 12, 2024
@snicoll snicoll self-assigned this Mar 12, 2024
@snicoll snicoll added this to the 6.1.5 milestone Mar 12, 2024
@snicoll
Copy link
Member

snicoll commented Mar 12, 2024

Good catch @KimJejun.

@snicoll snicoll changed the title ReactorNettyClientRequestFactory setExchangeTimeout descriptions is incorrect Javadoc of ReactorNettyClientRequestFactory#setExchangeTimeout methods have wrong default value Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

3 participants