Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cannot resolve ServerRequest::pathVariable in nested RequestPredicate again #31732

Closed
nise-nabe opened this issue Dec 1, 2023 · 3 comments
Closed

cannot resolve ServerRequest::pathVariable in nested RequestPredicate again #31732

nise-nabe opened this issue Dec 1, 2023 · 3 comments
Assignees
@poutsma
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: regression A bug that is also a regression
Milestone
6.1.2

Comments

@nise-nabe
Copy link

Affects: 6.1.1

It seems to be regression #26163 on spring boot 3.2.0.
I checked 6.1.0-M4 is work and 6.1.0-M5 is not work.
I guess, 39786e4 is affect to this.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 1, 2023
@poutsma poutsma self-assigned this Dec 1, 2023
@poutsma
Copy link
Contributor

poutsma commented Dec 1, 2023 •
edited
Loading

We have a test that should verify this scenario, see

spring-framework/spring-webmvc/src/test/java/org/springframework/web/servlet/function/RouterFunctionsTests.java

Line 102 in 1734dec

public void nestPathVariable() {
, but looking at the sample code in #26163 not all scenarios are tested.

Specifically, the /person2/{id} and /person4/{id} handlers from the sample in #26163 do not work on 6.1.1.

@poutsma poutsma added in: web Issues in web modules (web, webmvc, webflux, websocket) type: regression A bug that is also a regression and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 1, 2023
@poutsma poutsma added this to the 6.1.2 milestone Dec 1, 2023
@poutsma
Copy link
Contributor

poutsma commented Dec 1, 2023

This indeed due to 39786e4. Changes in the request attributes, like uri template variables, have not been been committed yet when the custom request predicate is evaluated.

@poutsma poutsma closed this as completed in 52d4b83 Dec 5, 2023
@poutsma
Copy link
Contributor

poutsma commented Dec 5, 2023

Thanks for reporting this, it should be fixed in 6.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: regression A bug that is also a regression
Projects
None yet
Milestone
6.1.2
Development

No branches or pull requests
3 participants
@poutsma @nise-nabe @spring-projects-issues