Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently log exceptions from TestExecutionListeners at WARN level #31688

Closed
sbrannen opened this issue Nov 26, 2023 · 0 comments
Closed

Consistently log exceptions from TestExecutionListeners at WARN level #31688

sbrannen opened this issue Nov 26, 2023 · 0 comments
Assignees
@sbrannen
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone
6.1.2

Comments

@sbrannen
Copy link
Member

As mentioned in #31479, the TestContextManager currently logs an exception from a TestExecutionListener at WARN level except in prepareTestInstance() where such an exception is logged at ERROR level (unless it's a skipped exception).

For consistency, we should always log non-skipped exceptions from TestExecutionListeners at WARN level.
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement labels Nov 26, 2023
@sbrannen sbrannen added this to the 6.1.2 milestone Nov 26, 2023
@sbrannen sbrannen self-assigned this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.2
Development

No branches or pull requests
1 participant
@sbrannen