Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP server exchange observations have incorrect UNKNOWN status tag if the client disconnected #31388

Closed
bclozel opened this issue Oct 9, 2023 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Oct 9, 2023

As seen in #31365, our HTTP server observations mark the response status tag as "UNKNOWN" if the client has disconnected. We could instead refine the behavior there and only use this status if the response has not been committed.

  • if the response has been committed, we known that this status was intended
  • if the response was not committed when the exchange was cancelled, we're not sure that the current status was indeed the intended one. Depending on the underlying server, there might be a default value set at that point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant